Remove DnsCacheListener from DnsCache when resolver is closed - #6174
Merged
trustin merged 2 commits intoMar 27, 2025
Conversation
yzfeng2020
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
March 26, 2025 05:42
Contributor
trustin
approved these changes
Mar 27, 2025
trustin
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for fixing this, @yzfeng2020! I left one nit, but it looks great! 🙇
ikhoon
approved these changes
Mar 27, 2025
jrhee17
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The
RefreshingAddressResolveris added to theDnsCacheas listener but is never removed from it when the resolver is closed. This makes theDnsCachehold a strong reference (internally, in theCopyOnWriteArrayListthat stores all the listeners) of it even when the resolver is closed, which may cause memory leak if theDnsCacheis a global one and lives for the lifetime of the JVM.Modifications:
DnsCacheListenerfrom theDnsCacheto make it eligible for GC.Result:
DnsCacheno longer stores it in the list and hence no longer holds a reference of it.